feat: use epoch block oracle subgraph for supported networks #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maikol
force-pushed
the
mde/use-ebo-subgraph-for-supported-networks
branch
from
73e037a
to
8389340
Compare
tmigone
approved these changes
May 10, 2024
| @@ -11,6 +11,9 @@ FLAGS: | |||
| -V, --version Prints version information | |||
|
|
|||
| OPTIONS: | |||
| --epoch-block-oracle-subgraph <subgraph> | |||
| Graphql endpoint to the epoch block oracle subgraph used for fetching supported networks [env: EPOCH_BLOCK_ORACLE_SUBGRAPH=] | |||
There was a problem hiding this comment.
should we provide the arbitrum subgraph as default since we don't expect this to change?
There was a problem hiding this comment.
We'll have to switch to the network so you'll need to provide an apiKey we could separate the parameters for url and apiKey but you'll still need to set it up for testnet too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Based on changes proposed in PR #255 we will be able to use the Epoch Block Oracle Subgraph to get the list of supported networks instead of passing the list as a configuration parameter.
Dependencies
This PR is dependent on the approval, merge and publish of PR #255. The changes here should only be merged after PR #255 is successfully integrated and the updates are available.