Upgrade GraphiQL to 1.5.1

[boulc]

Context

The goal is to add support request headers in GraphiQL (discussed in #504).

Description

Request headers support has been added in recent versions of GraphiQL. Unfortunately, GraphiQL with extensions does not support it. As it wraps the GraphiQL component and masks the props, upgrading has no effect. There is not much activity on graphiql-with-extensions repo since some time now.

The current integration of GraphiQL has a broken support of subscription (see #544), due to the deprecation of subscribe function in apollographql/subscriptions-transport-ws#272. Also this dependency is still required though not maintained anymore until #492 is resolved. For the same reason, the current integration relies on graphiql-subscriptions-fetcher which is archived and not maintained anymore, also wrapping the GraphQLFetcher and masking the additional options necessary to support request headers.

Proposal

1. Upgrading GraphiQL to version 1.5.1: cshtml file is inspired from CDN example.

2. Adding an option to enable/disable GraphiQL with extensions: ExplorerExtensionEnabled, enabled by default for backward compatibility.

3. Adding an option to enable/disable header editor: HeaderEditorEnabled, enable by default (same as in GraphiQL).

4. Wrapping subscriptionsFetcher to pass additional option to support request headers editor.

5. Downgrade subscriptions-transport-ws to version 0.8.2 to fix Subscriptions didnt work out of the box in current examples and readme.md #544.

Tests

Screenshot of side by side example of a mutation on the left leading to a working subscription on the right:

On the previous screenshot, the request headers editor is visible on the right and the authorization header is available in HTTP context when debugging:

[sungam3r]

@boulc I remember about this PR. Too much work these days.

[sungam3r]

I need some time to check.

[sungam3r]

@boulc Thanks for the fix. I don't know JS. I roughly understood what was happening here. I have two questions after which I will be glad to merge.

[Shane32]

@boulc @sungam3r Status? Waiting on this PR to release 5.2

[boulc]

I had some issues with missing SubscriptionDocumentExecuter while testing my latest changes so I had to add the dependency to GraphQL.SystemReactive to call AddSubscriptionDocumentExecuter extension (see 18cfa9d).
Also, I am suggesting another tweak to the sample, changing sentAt attribute from Date to DateTime nullable type and defaulting it to DateTime.UtcNow so it changes each time the mutation is executed: in the example below, the subscription reflects the mutation execution more accurately without having to change the mutation input to validate:

[Shane32]

Looks good. @sungam3r all set?

[codecov-commenter]

Codecov Report

Merging #649 (001ffad) into master (bed99b0) will decrease coverage by 0.00%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master     #649      +/-   ##
==========================================
- Coverage   50.27%   50.27%   -0.01%     
==========================================
  Files          68       68              
  Lines        1838     1842       +4     
  Branches      184      185       +1     
==========================================
+ Hits          924      926       +2     
- Misses        860      862       +2     
  Partials       54       54              

Impacted Files	Coverage Δ
src/Ui.GraphiQL/Internal/GraphiQLPageModel.cs	0.00% <0.00%> (ø)
src/Ui.GraphiQL/GraphiQLOptions.cs	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bed99b0...001ffad. Read the comment docs.

[sungam3r]

Wait a minute.