Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix content-type bug #656

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Fix content-type bug #656

merged 1 commit into from
Nov 23, 2021

Conversation

sungam3r
Copy link
Member

I checked all middlewares in Firefox first. Then I noticed that Playground doesn't work in Chrome. See comments.

@sungam3r sungam3r requested a review from Shane32 November 23, 2021 21:46
@sungam3r sungam3r added the bugfix Pull request that fixes a bug label Nov 23, 2021
@sungam3r
Copy link
Member Author

I think that it should be released as 5.1 - just recreate a tag after regenerating nuget token.

@codecov-commenter
Copy link

Codecov Report

Merging #656 (984b095) into master (24419f0) will decrease coverage by 0.31%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
- Coverage   55.18%   54.86%   -0.32%     
==========================================
  Files          64       64              
  Lines        1573     1582       +9     
  Branches      158      158              
==========================================
  Hits          868      868              
- Misses        651      660       +9     
  Partials       54       54              
Impacted Files Coverage Δ
src/Ui.Playground/Internal/PlaygroundPageModel.cs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24419f0...984b095. Read the comment docs.

@sungam3r sungam3r merged commit 019dad1 into master Nov 23, 2021
@sungam3r sungam3r deleted the fix-header branch November 23, 2021 23:59
@sungam3r sungam3r added this to the v5.1 milestone Nov 23, 2021
@sungam3r sungam3r modified the milestones: v5.1, v5.2 Dec 6, 2021
@basvandriel
Copy link

This still seems to be an issue. Any update on here?

@Shane32
Copy link
Member

Shane32 commented Dec 7, 2021

You downloaded version 5.1.0 (released yesterday) and still having an issue @basvandriel ?

@basvandriel
Copy link

basvandriel commented Dec 7, 2021

Yeah! I still get the content-type bug and the 2 prefixed headers. @Shane32

@sungam3r
Copy link
Member Author

sungam3r commented Dec 7, 2021

Unfortunately this commit is not included in v5.1.0

@sungam3r
Copy link
Member Author

sungam3r commented Dec 7, 2021

Wait a bit. I'll release v5.1.1.

@sungam3r sungam3r removed this from the v5.2 milestone Dec 7, 2021
@sungam3r
Copy link
Member Author

sungam3r commented Dec 7, 2021

https://github.com/graphql-dotnet/server/releases/tag/5.1.1

@basvandriel
Copy link

Did the job! Why is there a default "Accept": "application/json" though? Is it nessacery? @sungam3r

@sungam3r
Copy link
Member Author

sungam3r commented Dec 8, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants