Skip to content

Make WebSocketConnection.Connect virtual #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 26, 2021
Merged

Conversation

Shane32
Copy link
Member

@Shane32 Shane32 commented Dec 25, 2021

I'm trying to write an alternate implementation of IWebSocketConnectionFactory<TSchema> and cannot do so without this change.

For the next major version, IWebSocketConnectionFactory.CreateConnection should return an interface instead of a class.

@Shane32 Shane32 requested a review from sungam3r December 25, 2021 04:48
@Shane32 Shane32 self-assigned this Dec 25, 2021
@github-actions github-actions bot added the test label Dec 25, 2021
@sungam3r sungam3r added enhancement New feature or request and removed test labels Dec 25, 2021
@github-actions github-actions bot added the test label Dec 26, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #674 (8df7dc2) into master (fe16988) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #674   +/-   ##
=======================================
  Coverage   55.02%   55.02%           
=======================================
  Files          64       64           
  Lines        1592     1592           
  Branches      158      158           
=======================================
  Hits          876      876           
  Misses        662      662           
  Partials       54       54           
Impacted Files Coverage Δ
...ts.Subscriptions.WebSockets/WebSocketConnection.cs 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe16988...8df7dc2. Read the comment docs.

@Shane32 Shane32 merged commit d4090a7 into master Dec 26, 2021
@Shane32 Shane32 deleted the websocketconnection_virtual branch December 26, 2021 15:46
@Shane32 Shane32 added this to the v5.2 milestone Dec 27, 2021
@Shane32 Shane32 linked an issue Jan 5, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IWebSocketConnectionFactory cannot be reimplemented
3 participants