Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-TFM approvals #675

Merged
merged 6 commits into from
Dec 28, 2021
Merged

Multi-TFM approvals #675

merged 6 commits into from
Dec 28, 2021

Conversation

sungam3r
Copy link
Member

@sungam3r sungam3r commented Dec 25, 2021

Waiting for #665

@github-actions github-actions bot added the test label Dec 25, 2021
@sungam3r sungam3r self-assigned this Dec 25, 2021
@Shane32
Copy link
Member

Shane32 commented Dec 27, 2021

The code seems to be working fairly well in the GraphQL.NET project. One thing: right now when one TFM fails, it won't run the other TFM check. So it is necessary to run the api tests, rename the one file, and then run the tests again and rename the other file. Can we have it compare/update both files before returning a failure to the test? For example, start two tasks with Task.Run and then after a WhenAll then await one and the other or something?

@sungam3r
Copy link
Member Author

One thing: right now when one TFM fails, it won't run the other TFM check.

I know 😄 . Already thought about it.

@sungam3r
Copy link
Member Author

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@github-actions github-actions bot added the CI CI configuration issue or pull request label Dec 27, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov-commenter
Copy link

Codecov Report

Merging #675 (73e0970) into master (f7659c8) will increase coverage by 0.73%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #675      +/-   ##
==========================================
+ Coverage   51.15%   51.88%   +0.73%     
==========================================
  Files          68       68              
  Lines        1779     1779              
  Branches      172      172              
==========================================
+ Hits          910      923      +13     
+ Misses        821      808      -13     
  Partials       48       48              
Impacted Files Coverage Δ
src/Core/DefaultGraphQLExecuter.cs 25.00% <0.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7659c8...73e0970. Read the comment docs.

@sungam3r
Copy link
Member Author

Ported from GraphQL.NET

@sungam3r sungam3r requested a review from Shane32 December 27, 2021 21:55
@sungam3r sungam3r added this to the v5.2 milestone Dec 27, 2021
@sungam3r sungam3r merged commit 7017816 into master Dec 28, 2021
@sungam3r sungam3r deleted the multitfm branch December 28, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI configuration issue or pull request test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants