-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-TFM approvals #675
Multi-TFM approvals #675
Conversation
The code seems to be working fairly well in the GraphQL.NET project. One thing: right now when one TFM fails, it won't run the other TFM check. So it is necessary to run the api tests, rename the one file, and then run the tests again and rename the other file. Can we have it compare/update both files before returning a failure to the test? For example, start two tasks with Task.Run and then after a WhenAll then await one and the other or something? |
I know 😄 . Already thought about it. |
Codecov Report
@@ Coverage Diff @@
## master #675 +/- ##
==========================================
+ Coverage 51.15% 51.88% +0.73%
==========================================
Files 68 68
Lines 1779 1779
Branches 172 172
==========================================
+ Hits 910 923 +13
+ Misses 821 808 -13
Partials 48 48
Continue to review full report at Codecov.
|
Ported from GraphQL.NET |
Waiting for #665