Dispose all subscriptions when connection broken

[Shane32]

This code ensures that all existing subscriptions are disposed when the connection is disposed. Of course if the shutdown is clean then there should be no difference. Also it prevents additional subscriptions from connecting after the connection is disposed. Also the subscription releases all held objects upon disposal - so in case the IObserverable does not properly release the observer after it is disposed, at least there won't be any held handles to the underlying WebSocket.

[sungam3r]

approvals?

[Shane32]

approvals?

Whoops! Should be good now.

[Shane32]

@sungam3r Merge if it looks good to you.

[Shane32]

@sungam3r Ready for review here.

[Shane32]

Just checked the code:

WebSocketConnectionFactory.CreateConnection:

• Creates WebSocketTransport and SubscriptionManager.
  • The WebSocketTransport disposes the underlying WebSocket
  • The SubscriptionManager disposes any Subscriptions it creates in a thread-safe manner.
    • Subscription instances dispose the underlying IDisposable returned from subscribing
• Creates SubscriptionServer which owns (and disposes) the SubscriptionManager and references the WebSocketTransport.
• Creates WebSocketConnection which owns (and disposes) WebSocketTransport and SubscriptionServer.
  • The WebSocketConnection is disposed by the using statement in the middleware for ASP.Net Core (GraphQLWebSocketsMiddleware).

This may sound confusing, but I'm pretty sure it's all correct.

[codecov-commenter]

Codecov Report

Merging #677 (8723272) into master (7017816) will decrease coverage by 2.22%.
The diff coverage is 23.40%.

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
- Coverage   52.44%   50.22%   -2.23%     
==========================================
  Files          68       68              
  Lines        1779     1818      +39     
  Branches      172      183      +11     
==========================================
- Hits          933      913      -20     
- Misses        798      851      +53     
- Partials       48       54       +6     

Impacted Files	Coverage Δ
...s.Subscriptions.Abstractions/SubscriptionServer.cs	94.04% <0.00%> (-1.14%)	⬇️
...ts.Subscriptions.WebSockets/WebSocketConnection.cs	0.00% <0.00%> (ø)
....Subscriptions.Abstractions/SubscriptionManager.cs	66.97% <4.00%> (-18.91%)	⬇️
...nsports.Subscriptions.Abstractions/Subscription.cs	80.95% <50.00%> (-15.05%)	⬇️
....Subscriptions.Abstractions/LogMessagesListener.cs	0.00% <0.00%> (-40.00%)	⬇️
src/Core/Extensions/ServiceCollectionExtensions.cs	56.52% <0.00%> (-26.09%)	⬇️
src/Core/DefaultGraphQLExecuter.cs	0.00% <0.00%> (-25.00%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7017816...8723272. Read the comment docs.