Provide service provider to subscription execution #691
+57
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungam3r
reviewed
Dec 30, 2021
tests/ApiApprovalTests/GraphQL.Server.Transports.Subscriptions.Abstractions.approved.txt
Show resolved
Hide resolved
sungam3r
reviewed
Dec 30, 2021
src/Transports.Subscriptions.WebSockets/WebSocketConnectionFactory.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Dec 30, 2021
src/Transports.Subscriptions.Abstractions/SubscriptionManager.cs
Outdated
Show resolved
Hide resolved
|
Nice fix. |
|
😠 |
Closed
Codecov Report
@@ Coverage Diff @@
## master #691 +/- ##
==========================================
+ Coverage 50.93% 50.97% +0.04%
==========================================
Files 68 68
Lines 1818 1838 +20
Branches 183 184 +1
==========================================
+ Hits 926 937 +11
- Misses 838 847 +9
Partials 54 54
Continue to review full report at Codecov.
|
sungam3r
reviewed
Dec 30, 2021
sungam3r
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #690
The new
IGraphQLBuilderextension methods rely on the service provider to be passed to the document executer. Without it, many of the extension methods will not function as intended.This PR creates a scope for the duration of the execution. The scope and acquired services are disposed immediately after execution completes. In this way, there are no unintended extremely-long lifetimes of scoped objects. Also, since execution only occurs at the start of a subscription, there is no need to hold the scope indefinitely. Services that provide the
IObservableinstances must still be singletons, as is required now, because if they were scoped then (a) they would not share the event stream data across multiple instances (b) they would be disposed when the execution is disposed.