Merge pull request #642 from Invizory/fix-infinite-recursion-in-parser

Fix infinite recursion in type definition parser
graphql-go · Apr 10, 2023 · a974186 · a974186
2 parents 623f886 + 2a6e1ff
commit a974186
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/language/parser/parser.go b/language/parser/parser.go
@@ -19,12 +19,6 @@ var tokenDefinitionFn map[string]parseDefinitionFn
 func init() {
 	tokenDefinitionFn = make(map[string]parseDefinitionFn)
 	{
-		// for sign
-		tokenDefinitionFn[lexer.BRACE_L.String()] = parseOperationDefinition
-		tokenDefinitionFn[lexer.STRING.String()] = parseTypeSystemDefinition
-		tokenDefinitionFn[lexer.BLOCK_STRING.String()] = parseTypeSystemDefinition
-		tokenDefinitionFn[lexer.NAME.String()] = parseTypeSystemDefinition
-		// for NAME
 		tokenDefinitionFn[lexer.FRAGMENT] = parseFragmentDefinition
 		tokenDefinitionFn[lexer.QUERY] = parseOperationDefinition
 		tokenDefinitionFn[lexer.MUTATION] = parseOperationDefinition
@@ -145,8 +139,10 @@ func parseDocument(parser *Parser) (*ast.Document, error) {
 			break
 		}
 		switch kind := parser.Token.Kind; kind {
-		case lexer.BRACE_L, lexer.NAME, lexer.STRING, lexer.BLOCK_STRING:
-			item = tokenDefinitionFn[kind.String()]
+		case lexer.BRACE_L:
+			item = parseOperationDefinition
+		case lexer.NAME, lexer.STRING, lexer.BLOCK_STRING:
+			item = parseTypeSystemDefinition
 		default:
 			return nil, unexpected(parser, lexer.Token{})
 		}

diff --git a/language/parser/parser_test.go b/language/parser/parser_test.go
@@ -736,6 +736,15 @@ func TestParseCreatesAst(t *testing.T) {
 
 }
 
+func TestDoesNotAcceptStringAsDefinition(t *testing.T) {
+	test := errorMessageTest{
+		`String`,
+		`Syntax Error GraphQL (1:1) Unexpected Name "String"`,
+		false,
+	}
+	testErrorMessage(t, test)
+}
+
 type errorMessageTest struct {
 	source          interface{}
 	expectedMessage string