modify make token by byte position, not rune position at readName

graphql-go · Jun 9, 2021 · ea0716e · ea0716e
1 parent 8a92e97
commit ea0716e
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/language/lexer/lexer.go b/language/lexer/lexer.go
@@ -129,7 +129,7 @@ func readName(source *source.Source, position, runePosition int) Token {
 			break
 		}
 	}
-	return makeToken(NAME, runePosition, endRune, string(body[position:endByte]))
+	return makeToken(NAME, position, endByte, string(body[position:endByte]))
 }
 
 // Reads a number token from the source file, either a float

diff --git a/language/lexer/lexer_test.go b/language/lexer/lexer_test.go
@@ -91,8 +91,8 @@ func TestLexer_AcceptsBOMHeader(t *testing.T) {
 			Body: "\uFEFF foo",
 			Expected: Token{
 				Kind:  NAME,
-				Start: 2,
-				End:   5,
+				Start: 4,
+				End:   7,
 				Value: "foo",
 			},
 		},

diff --git a/language/parser/parser_test.go b/language/parser/parser_test.go
@@ -498,6 +498,19 @@ func TestParsesEnumValueDefinitionWithDescription(t *testing.T) {
 	}
 }
 
+func TestParsesTypeDefinitionWithMultiByteCharactersComment_UnicodeText(t *testing.T) {
+	source := `
+	    # This comment has a фы世界 character.
+	    type Foo implements Bar {
+	        foo: String!
+	    }
+	`
+	_, err := Parse(ParseParams{Source: source})
+	if err != nil {
+		t.Fatalf("unexpected error: %v", err)
+	}
+}
+
 func TestDefinitionsWithDescriptions(t *testing.T) {
 	testCases := []struct {
 		name            string