Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DateTime literal parsing #419

Merged

Conversation

ccbrown
Copy link
Contributor

@ccbrown ccbrown commented Nov 16, 2018

Fixes #250.

I moved the test file because I didn't want to create yet another file, but "parsevalue_test" would no longer by accurate after adding the ParseLiteral test.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 91.87% when pulling be84dc7 on ccbrown:fix-date-time-literal-parsing into a7e15c0 on graphql-go:master.

@chris-ramon
Copy link
Member

LGTM 👍 — thanks a lot @ccbrown

@chris-ramon chris-ramon merged commit 993e01c into graphql-go:master Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants