Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go Modules. #425

Merged
merged 1 commit into from Dec 2, 2018
Merged

Use Go Modules. #425

merged 1 commit into from Dec 2, 2018

Conversation

chris-ramon
Copy link
Member

@chris-ramon chris-ramon commented Dec 2, 2018

Overview

  • Re-created from: Use Go Modules.Β #408 β€” thanks a lot @zonr πŸ‘
  • Added ci/circleci: golang:1.11 as required status check for every pull-request.

This is done via the following command with Go 1.11:

$ go mod init github.com/graphql-go/graphql
go: creating new go.mod: module github.com/graphql-go/graphql
$ go mod tidy

Using Go Modules removes the need to develop/build the project in a
$GOPATH-based location. More specifically, with latest Go, setting up
development environment can be as simple as:

/under/whatever/path $ git clone https://github.com/graphql-go/graphql # or your own fork
/under/whatever/path $ go test ./...

Also instruct CircleCI to run tests with Go Modules when latest Go is in
use. See https://circleci.com/blog/go-v1.11-modules-and-circleci/.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.87% when pulling 31bba03 on enable-go-module into 993e01c on master.

This is done via the following command with Go 1.11:

```
$ go mod init github.com/graphql-go/graphql
go: creating new go.mod: module github.com/graphql-go/graphql
$ go mod tidy
```

Using Go Modules removes the need to develop/build the project in a
`$GOPATH`-based location. More specifically, with latest Go, setting up
development environment can be as simple as:

```
/under/whatever/path $ git clone https://github.com/graphql-go/graphql # or your own fork
/under/whatever/path $ go test ./...
```

Also instruct CircleCI to run tests with Go Modules when latest Go is in
use. See https://circleci.com/blog/go-v1.11-modules-and-circleci/.
@chris-ramon chris-ramon mentioned this pull request Dec 2, 2018
@chris-ramon chris-ramon merged commit 8000299 into master Dec 2, 2018
@chris-ramon chris-ramon deleted the enable-go-module branch December 2, 2018 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants