Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors: consolidates original error for re-usability #427

Merged
merged 1 commit into from Dec 10, 2018
Merged

errors: consolidates original error for re-usability #427

merged 1 commit into from Dec 10, 2018

Conversation

chris-ramon
Copy link
Member

@chris-ramon chris-ramon commented Dec 9, 2018 •
edited

Overview

Breaking Changes

  • No breaking changes for non-users of FormattedError.OriginalError().
  • If using FormattedError.OriginalError():
    • Now FormattedError.OriginalError() returns the actual error that was pass to gqlerrors.FormatError.

Test plan

  • Unit tests

@chris-ramon chris-ramon merged commit 21fe71d into master Dec 10, 2018
@chris-ramon chris-ramon deleted the original-error-improvements branch December 10, 2018 00:06
@chris-ramon chris-ramon mentioned this pull request Dec 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@chris-ramon