Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our project we do thousands of
printer.Print
calls per second, so its performance is critical for us.As it is,
printer.Print
is rather slow, see issue #674 for some comparisons.This is caused by its use of
json.Marshal
andjson.Unmarshal
as a way of converting interfaces tomap[string]interface{}
in theconvertMap
method.This PR replaces the JSON logic with a custom, reflection based converter instead.
It also adds a benchmark to measure the performance impact.
Before the changes:
After the changes:
Roughly a 10x speedup. There might be some edge-cases I have missed, but looks like
convertMap
conforms to the behavior of its previous version.Fixes #674