Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency com.graphql-java:graphql-java to v17 #560

Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 3, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.graphql-java:graphql-java 16.2 -> 17.0 age adoption passing confidence

Release Notes

graphql-java/graphql-java

v17.0

Compare Source

We are happy to announce v17.0 of graphql-java

https://github.com/graphql-java/graphql-java/milestone/31?closed=1

@deprecated supported on input fields

In line with coming graphql spec changes, the @deprecated annotation can now be placed on input fields and not just output fields as before.

graphql-java/graphql-java#2186

Dramatic performance improvements in GraphQLSchema building

The GraphQLSchema is a graph of types and as such has to be built according to strict rules. The previous code would repeated visit and rebuilt the schema and this meant that large schemes could be slow to build.

This code has been extensively benchmarked and improved. For example on a very large and complex schema, total build time went from 3.5 seconds to 1.2 seconds.

Thank you to teams out there that used https://github.com/graphql-java/graphql-anonymizer to submit in real life schemas that we can test with.

Dramatic performance improvements in DataFetchingFieldSelectionSet

The classes that underlie the DataFetchingFieldSelectionSet code have been been remodelled to be dramatically more performant. Before interfaces could create an exponential explosion in objects created. This has been fixed which in turn improves the performance of this code as scale.

Dramatic performance improvements in large query validation

The graphql spec calls for overlapping fields in fragments to be validated in a certain way. The previous code followed the specs psudeo-algorithm correctly but it leads to asymptotic performance problems.

This has been rewritten via graphql-java/graphql-java#2495 based on this article https://tech.xing.com/graphql-overlapping-fields-can-be-merged-fast-ea6e92e0a01 which dramatically improves how fast large queries can validated.

Support of directives on fields and types during introspection

#​2221 this is a non spec feature which lets you expose directives through Introspection

Reworked default value validation and improved Scalar coercion

#​2325 This is a relatively big change which fixed up how default values are processed. Before that default values were never validated and custom Scalars could cause invalid values printed in SDL or Introspection. This PR includes a new Scalar coercion function valueToLiteral which is needed to implement this correct behaviour.

Better Unicode support in documents

graphql-java/graphql-java#2404 allows for better Unicode expression in queries and SDL documents

GraphQLContext is now the approved context mechanism

graphql-java/graphql-java#2368 allows for a well known API for context within a graphql request. Previously any opaque object could be used and framework could was not able to make any assumptions about adding their own context properties

The old mechanism has been deprecated and a singleton (buy mutable) context object is now how context is passed around.

Ignored characters are no longer help in memory by default

Characters in a graphql document that are not significant to the syntax, such as spaces, new lines and comms, used to be captured in memory against AST nodes.

This is no longer the case and it saves memory from parsed documents. There is a switch to turn on the old behavior intended for tooling code.

graphql-java/graphql-java#2394

Exception handlers can now be asynchronous

graphql-java operates in a asynchronous world and hence the code that handles exceptions in data fetchers should itself allow asynchronous handling.

graphql-java/graphql-java#2371

Breaking changes

https://github.com/graphql-java/graphql-java/pulls?q=is%3Apr+label%3A%22breaking+change%22++milestone%3A%2217.0%22

  • The boolean values acceptable as variable input the Boolean scalar have been tightened to true and false - see Strict boolean support for Strings in and out graphql-java/graphql-java#2419

  • The non standard @Fetch directive support has been removed by default and deprecated. This was done for performance reasons because very few people used it but it slowed down schema creation a lot

  • The long deprecated BatchedExecutionStrategy and ExecutorServiceExecutionStrategy have finally been removed


Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Aug 3, 2021
@renovate renovate bot force-pushed the renovate/major-graphql-java-(ignoring-snapshot-builds) branch from 6cd3c51 to fdf3345 Compare August 3, 2021 13:05
@oryan-block oryan-block force-pushed the renovate/major-graphql-java-(ignoring-snapshot-builds) branch from 388e340 to 61b80a4 Compare August 4, 2021 19:05
@oryan-block oryan-block force-pushed the renovate/major-graphql-java-(ignoring-snapshot-builds) branch from 61b80a4 to f1adcd9 Compare August 4, 2021 19:11
// since we don't pass in the full set of discovered directives
return super.buildDirective(null, directive, setOf(graphQLDirective), directiveLocation, comparatorRegistry)
val context = BuildContext(TypeDefinitionRegistry(), MOCKED_WIRING, emptyMap(), defaultOptions())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't pass null here anymore.
This should keep working for now, but we might want to think of a better approach.

@oryan-block oryan-block merged commit 6abf314 into master Aug 13, 2021
@oryan-block oryan-block deleted the renovate/major-graphql-java-(ignoring-snapshot-builds) branch August 13, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants