This will validate @oneOf variable values when the variables are coerced #3580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ced - fixed tests
bbakerman
commented
Apr 28, 2024
| static Object externalValueToInternalValueImpl( | ||
| String variableName, |
There was a problem hiding this comment.
needed to add a variable name for error message reasons
bbakerman
commented
Apr 28, 2024
| when: | ||
| def resolvedValues = ValuesResolver.coerceVariableValues(schema, [variableDefinition], RawVariables.of([variable: [a: 'x']]), graphQLContext, locale) | ||
| then: | ||
| resolvedValues.get('variable') == [a: 'x'] |
There was a problem hiding this comment.
one is ok - or the other is ok but not both
bbakerman
commented
Apr 28, 2024
| @@ -169,14 +169,14 @@ class GraphQLInputObjectTypeTest extends Specification { | |||
| er = graphQL.execute(ei) | |||
| then: | |||
| !er.errors.isEmpty() | |||
| er.errors[0].message == "Exception while fetching data (/f) : Exactly one key must be specified for OneOf type 'OneOf'." | |||
| er.errors[0].message == "Exactly one key must be specified for OneOf type 'OneOf'." | |||
There was a problem hiding this comment.
now caught earlier during variable value coercion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will call the oneOf validation during the coercion of the variables during execution.
This MAY make the later validation during argument retrieval slightly redundant however there are other paths that can enter this value code so I have left it in place
This PR plus #3577 will mean variables and literals are covered