Ready: Add @deprecated validation for input object fields, field arguments, directive arguments #3591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dondonz
changed the title
bbakerman
reviewed
May 14, 2024
| @Override | ||
| public TraversalControl visitGraphQLInputObjectField(GraphQLInputObjectField inputObjectField, TraverserContext<GraphQLSchemaElement> context) { | ||
| // There can only be at most one @deprecated, because it is not a repeatable directive | ||
| GraphQLAppliedDirective deprecatedDirective = inputObjectField.getAppliedDirective("deprecated"); |
There was a problem hiding this comment.
Use Directives.Deprecated.getName() perhaps to stop string spread
There was a problem hiding this comment.
Yes that's a better idea, I'll add that. Don't want a random string hanging out here
There was a problem hiding this comment.
I fixed both strings in the commit after your review
bbakerman
reviewed
May 14, 2024
| @Override | ||
| public TraversalControl visitGraphQLArgument(GraphQLArgument argument, TraverserContext<GraphQLSchemaElement> context) { | ||
| // There can only be at most one @deprecated, because it is not a repeatable directive | ||
| GraphQLAppliedDirective deprecatedDirective = argument.getAppliedDirective("deprecated"); |
There was a problem hiding this comment.
string constant suggestion as abovee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3590
From the GraphQL specification:
This PR adds the schema validation rule to enforce this line of the spec.