Adding missed properties on IncrementalExecutionResultImpl.Builder.from #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dondonz
reviewed
May 13, 2024
| @@ -91,6 +91,8 @@ public Builder incrementalItemPublisher(Publisher<DelayedIncrementalPartialResul | |||
| public Builder from(IncrementalExecutionResult incrementalExecutionResult) { | |||
| super.from(incrementalExecutionResult); | |||
| this.hasNext = incrementalExecutionResult.hasNext(); | |||
| this.incremental = incrementalExecutionResult.getIncremental(); | |||
| this.incrementalItemPublisher = incrementalExecutionResult.getIncrementalItemPublisher(); | |||
There was a problem hiding this comment.
Perhaps you were already in the progress of doing it. Could you please add a test for this?
There was a problem hiding this comment.
I've added the tests, check out: src/test/groovy/graphql/incremental/IncrementalExecutionResultTest.groovy
dondonz
reviewed
May 17, 2024
| newIncrementalExecutionResult.errors == incrementalExecutionResult.errors | ||
| newIncrementalExecutionResult.incrementalItemPublisher == incrementalExecutionResult.incrementalItemPublisher | ||
| newIncrementalExecutionResult.hasNext() == incrementalExecutionResult.hasNext() | ||
| newIncrementalExecutionResult.toSpecification() == newIncrementalExecutionResult.toSpecification() |
There was a problem hiding this comment.
I think this was a tiny typo, did you mean:
Suggested change
| newIncrementalExecutionResult.toSpecification() == newIncrementalExecutionResult.toSpecification() | |
| newIncrementalExecutionResult.toSpecification() == incrementalExecutionResult.toSpecification() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding two missed properties on IncrementalExecutionResultImpl.Builder.from