Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Minimum GraphQL v16 support #1017

Merged
merged 1 commit into from Nov 18, 2021

Conversation

tgriesser
Copy link
Member

Fixes #1009

@tgriesser tgriesser merged commit 9ec3442 into main Nov 18, 2021
@tgriesser tgriesser deleted the tgriesser/fix/minimum-graphql-16-support branch November 18, 2021 20:53
@darrylyoung
Copy link
Contributor

Thanks for the quick fix with this, @tgriesser. Will the non-beta 1.2.0 be releasing soon or is it recommended to use next?

@tgriesser
Copy link
Member Author

Just use next for now if you can, probably won't get around to cutting 1.2.0 for a few weeks.

@kjkent
Copy link

kjkent commented Feb 15, 2022

Hi @tgriesser. With this PR merged, is Nexus compatible with GraphQL 16? Just wanted to check as the package.json on the latest NPM package still has peerDependencies: "graphql": "^14.5.8 || 15.x" and I wasn't sure if it was appropriate to open an issue about this. Cheers.

@tgriesser
Copy link
Member Author

It is in a runtime sense, but not fully from a type-safety standpoint yet, that'll require #1017 - was working on that the other day and still needed to fix up some of the integration tests. Will keep working on it this week

@kjkent
Copy link

kjkent commented Feb 15, 2022

Amazing; thanks for the update, it's appreciated.

tgriesser added a commit that referenced this pull request Feb 16, 2022
* main:
  chore(docs): fix typos (#1005)
  chore(docs): fix typo 06-chapter-5-persisting-data-via-prisma.mdx (#1007)
  chore(docs): fix typo 04-why-nexus.mdx (#1008)
  chore(docs): fix typo 030-neuxs-framework-prisma-users.mdx (#1016)
  chore(docs): fix typo 05-chapter-4-testing-your-api.mdx (#1023)
  chore(docs): fix typo in 07-chapter-6-testing-with-prisma.mdx (#1024)
  fix: Minimum GraphQL v16 support (#1017)
  chore(docs): add Example Code (#948)
  chore(docs): Update Ordering section (#950)
  chore(docs): Nexus Getting started: missing type in queryType (#995)
  chore(docs): readme update -- fix code sample to include ".ts" in module path (#998)
  chore(docs): typo fix in docs (#999)
  chore(docs): change package get-port ver in tutorial (#1000)
  docs: change all "npm add" to "npm install" (#991)
  docs: Update 061-list-nonNull.mdx (#986)
  feat: Add mergeSchema, better graphql-js interop (#983)
  refactor: More internal cleanup (#981)
  refactor: Internal type cleanup (#980)
  refactor: remove duplicate core schema type checks (#978)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix for graphql 16: GraphQLNonNull cannot be invoked without 'new'
3 participants