Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update testing.rst #1026

Merged
merged 1 commit into from Aug 26, 2020
Merged

Update testing.rst #1026

merged 1 commit into from Aug 26, 2020

Conversation

donegjookim
Copy link
Contributor

  • Import json as a dependency
  • Add a missing colon on the function definition

@ulgens
Copy link
Collaborator

ulgens commented Aug 20, 2020

Why json is required in that code fragment?

@DoctorJohn
Copy link
Contributor

Why json is required in that code fragment?

The json import is indeed used at the end of the code snippet. (It doesn't show the full snippet in the code diff view).

jkimbo
jkimbo approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @donegjookim

@jkimbo jkimbo merged commit f5d94fd into graphql-python:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkimbo jkimbo jkimbo approved these changes

@r0n4ld r0n4ld r0n4ld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@donegjookim @ulgens @DoctorJohn @jkimbo @r0n4ld