Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Unidecode package with text_unidecode package #1060

Merged
merged 1 commit into from Dec 23, 2020
Merged

Replace Unidecode package with text_unidecode package #1060

merged 1 commit into from Dec 23, 2020

Conversation

artofhuman
Copy link
Contributor

Closes #1014

@artofhuman artofhuman changed the title Replace Unidecode package with text_unidecode package #1014 Replace Unidecode package with text_unidecode package Nov 8, 2020
zbyte64
zbyte64 approved these changes Nov 9, 2020
View reviewed changes
Copy link
Collaborator

@zbyte64 zbyte64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

What helped convince me was watching wagtail respond to this issue: wagtail/wagtail#3311

@joricht joricht mentioned this pull request Nov 12, 2020
Closed
@zbyte64 zbyte64 merged commit cc3bd05 into graphql-python:master Dec 23, 2020
@artofhuman artofhuman deleted the change-unidecode branch December 23, 2020 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbyte64 zbyte64 zbyte64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Unidecode package with text_unidecode package
2 participants
@artofhuman @zbyte64