Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default msg to show the response content. #1064

Merged
merged 2 commits into from Nov 27, 2020

Conversation

jackton1
Copy link
Contributor

@jackton1 jackton1 commented Nov 18, 2020

This seems like an issue with using assertResponseNoErrors and assertResponseHasErrors

Which doesn't include any errors specific to the response and currently just shows.

    self.assertNotIn("errors", list(content.keys()))
AssertionError: 'errors' unexpectedly found in ['errors', 'data']

Expected:

self.assertNotIn("errors", list(content.keys()), content)
AssertionError: 'errors' unexpectedly found in ['errors', 'data'] : {'errors': [{'message': "mutate() missing 1 required positional argument: 'info'", 'locations': [{'line': 3, 'column': 17}], 'path': ['eventCancel']}], 'data': None}

@artofhuman @syrusakbary

This seems like an issue with using assertResponseNoErrors and assertResponseHasErrors 

Which doesn't include any errors specific to the response and currently just shows.

```python
    self.assertNotIn("errors", list(content.keys()))
AssertionError: 'errors' unexpectedly found in ['errors', 'data']
```
Copy link
Collaborator

@zbyte64 zbyte64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice polish

@tcleonard
Copy link
Collaborator

Nice

@zbyte64 zbyte64 merged commit 4b7119d into graphql-python:master Nov 27, 2020
@jackton1 jackton1 deleted the patch-1 branch December 11, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants