Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: convert decimal field to graphene decimal #1083

Merged
merged 1 commit into from
Dec 30, 2020
Merged

improvement: convert decimal field to graphene decimal #1083

merged 1 commit into from
Dec 30, 2020

Conversation

zbyte64
Copy link
Collaborator

@zbyte64 zbyte64 commented Dec 29, 2020

Fixes #91 by converting models.DecimalField to graphene's Decimal type

rganeyev
rganeyev approved these changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@rganeyev rganeyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the tests!

@ulgens ulgens self-requested a review December 30, 2020 02:33
@zbyte64 zbyte64 merged commit 2d0b9dd into graphql-python:master Dec 30, 2020
@ulgens ulgens mentioned this pull request Jan 2, 2021
Merged
@sjdemartini sjdemartini mentioned this pull request Mar 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulgens ulgens ulgens approved these changes

@rganeyev rganeyev rganeyev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert DecimalField to String rather than Float
3 participants
@zbyte64 @ulgens @rganeyev