Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GraphQLTransactionTestCase #1099

Merged
merged 7 commits into from Feb 23, 2021
Merged

Conversation

jackton1
Copy link
Contributor

@jackton1 jackton1 commented Jan 15, 2021

Adds support for testing mutations that are executed within a transaction block

Reference:

TODO:

  • Update documentation

@artofhuman @syrusakbary @zbyte64 @ulgens

@zbyte64 @ulgens any chance this PR could get reviewed soon ??

jackton1 and others added 7 commits January 15, 2021 14:29
- Adds support for testing code that is executed within a transaction

Reference: https://docs.djangoproject.com/en/3.1/topics/testing/tools/#django.test.TransactionTestCase
```
 For instance, you cannot test that a block of code is executing within a transaction, as is required when using select_for_update(). In those cases, you should use TransactionTestCase.
```
@zbyte64 zbyte64 requested a review from ulgens February 9, 2021 01:26
Copy link
Collaborator

@zbyte64 zbyte64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems appropriate 👍

@zbyte64 zbyte64 merged commit 5cee414 into graphql-python:main Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants