Doc clarification for headers arg in testing utils #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it might be helpful to add an explicit hint that HTTP headers should be prepended with `HTTP_` as required by `django.test.Client` (at least it was not super obvious to me when I tried to use it).
|
Great idea adding this call out to the docs. The failure is unrelated to your commit, I noticed someone had a PR that tacked on a fix: https://github.com/graphql-python/graphene-django/pull/1112/files#diff-1d9d6e9e707386e73d8f3b6766c664ff038fd4268bc2b7321e42468f7f31b437 |
|
Main branch should be fixed now. Please git fetch main, merge, and push to see if it resolves the build. |
zbyte64
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it might be helpful to add an explicit hint that HTTP headers should be prepended with
HTTP_as required bydjango.test.Client(at least it was not super obvious to me when I tried to use it).