Issue #1037: Update DjangoModelFormMutation to honor input_field_name #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eprikazc
changed the title
firaskafri
requested review from
jkimbo,
keithhackbarth,
tcleonard and
zbyte64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1037
To get custom input_field_name working and at the same not totouch
graphene.relay.mutation.ClientIDMutation, we do following:cls._meta.argumentsto move field from defaultinputfield to custom onemutatemethod to rename custom input field back toinputbefore calling superThis is my first contribution to django_graphene, please let me know if something should be changed/improved (perhaps tests are needed?)