Remove promise based debug middleware #1388
Merged
+20
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Potentially fixes #1387 |
|
Hello @jaw9c, this is great! |
firaskafri
approved these changes
Feb 17, 2023
|
Thanks @firaskafri - looks like the CI is broken as the tests pass locally. Just looked at them and appears to be an import error with the examples folder - https://github.com/graphql-python/graphene-django/actions/workflows/tests.yml |
jaw9c
force-pushed
the
fix/remove-promise-based-middleware
branch
4 times, most recently
from
9a464fb
to
2441c4f
Compare
jaw9c
force-pushed
the
fix/remove-promise-based-middleware
branch
from
2441c4f
to
e850ec2
Compare
|
@firaskafri Updated the PR, tests now get run correctly - was a problem with the python path not being set 👍 |
jkimbo
approved these changes
Feb 27, 2023
Thank you @jkimbo 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception handling by the debug middleware is broken. If using the toolbar middleware, then any exception raised in a resolver gets consumed and replaced with a cryptic
Thread poolrelated error.The root cause is that the graphql core lib expects the result of the call to exception instance rather than a rejected promise.
When the graphql core lib tries to resolve the promise as a normal result it results in the cryptic error.
I've also removed the reference to promises as they didn't seem to be helping anything (But please correct the PR if I'm missing something)