Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GraphiQL to 2.4.1 #1396

Merged
merged 1 commit into from Apr 17, 2023
Merged

Update GraphiQL to 2.4.1 #1396

merged 1 commit into from Apr 17, 2023

Conversation

kiendang
Copy link
Collaborator

Bump GraphiQL to the currently latest version 2.4.1.

Main changes:

  • Replace the now deprecated subscriptions-transport-ws with graphql-ws. Still keep subscriptions_transport_ws_version and subscriptions_transport_ws_sri inside GraphQLView instead of renaming to graphql_ws_version for backward compatibility though.
  • Use the built-in GraphiQL.createFetcher to create the fetcher instead of handrolling one.

@firaskafri firaskafri merged commit 3283d0b into graphql-python:main Apr 17, 2023
11 checks passed
@firaskafri firaskafri mentioned this pull request Apr 17, 2023
Closed
@kiendang kiendang deleted the graphiql-2.4.1 branch April 17, 2023 06:36
@kiendang kiendang mentioned this pull request May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firaskafri firaskafri firaskafri approved these changes

@mahdyhamad mahdyhamad mahdyhamad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kiendang @firaskafri @mahdyhamad