Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GraphiQL Explorer plugin #1397

Merged
merged 1 commit into from May 4, 2023

Conversation

kiendang
Copy link
Collaborator

@firaskafri
Copy link
Collaborator

@kiendang thank you! Would you please check the tests?

@kiendang
Copy link
Collaborator Author

@firaskafri looks like someone, not sure if it's you, triggered a test re-run and they all pass now.
tests all pass for me locally too. doesn't seem like the changes are related to the failure either.

@firaskafri firaskafri requested a review from jaw9c April 21, 2023 18:32
@sjdemartini
Copy link
Collaborator

I tested this locally with the example app in examples/cookbook-plain, and it looks great to me, thanks for adding this @kiendang!

Screenshot 2023-05-04 at 9 52 10 AM

I changed the examples/cookbook-plain/requirements.txt to the following to use the current local graphene-django code instead of the published version:

graphene
django~=3.2
../../  # graphene-django

@firaskafri firaskafri merged commit 52f9921 into graphql-python:main May 4, 2023
11 checks passed
@kiendang kiendang deleted the graphiql-explorer branch May 4, 2023 19:14
superlevure pushed a commit to loft-orbital/graphene-django that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GraphiQL Explorer
3 participants