fix: use execution_context_class attribute for GraphQLView #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaw9c
requested changes
Apr 20, 2023
graphene_django/views.py
Outdated
| @@ -112,7 +112,7 @@ def __init__( | |||
| self.pretty = self.pretty or pretty | |||
| self.graphiql = self.graphiql or graphiql | |||
| self.batch = self.batch or batch | |||
| self.execution_context_class = execution_context_class | |||
| self.execution_context_class = execution_context_class or self.execution_context_class | |||
There was a problem hiding this comment.
We probs want to follow the same pattern as the other attributes (graphiql, batch etc):
Suggested change
| self.execution_context_class = execution_context_class or self.execution_context_class | |
| self.execution_context_class = self.execution_context_class or execution_context_class |
There was a problem hiding this comment.
I think so this is not a good pattern. class attribute it's something like default value. when we create an instance we need to have approach to redefine it. thats why i use current order.
There was a problem hiding this comment.
@Arfey Nice, thats a good point - could you update the other attributes to follow that pattern instead?
|
@Arfey great PR! |
jaw9c
approved these changes
May 9, 2023
firaskafri
approved these changes
May 24, 2023
superlevure
pushed a commit
to loft-orbital/graphene-django
that referenced
this pull request
Jul 19, 2023
…ython#1398) * fix: use execution_context_class attribute for GraphQLView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change for using execution_context_class as class attribute