Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade github actions versions, default python and dev dependencies #1407

Merged
merged 12 commits into from May 3, 2023

Conversation

firaskafri
Copy link
Collaborator

@firaskafri firaskafri commented May 3, 2023

  • Use Python 3.10 in deploy.yml
  • Use Python 3.10 in lint.yml
  • Update setup-python and checkout versions
  • Update .pre-commit-config.yaml
  • Match dev dependencies versions with workflows
  • make format for examples files and migrations to follow the new black version
  • Upgrade pytest version

Copy link
Collaborator

@kiendang kiendang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the GH action from pypa/gh-action-pypi-publish@v1.1.0 (it's been 3 years) to pypa/gh-action-pypi-publish@release/v1 (the latest v1) as well. See https://github.com/pypa/gh-action-pypi-publish.

Also probably use 3.10 in lint.yml as well just for consistency.

@firaskafri firaskafri changed the title Use Python 3.10 for deployments on PyPi Tooling cleanups May 3, 2023
@firaskafri
Copy link
Collaborator Author

@kiendang You are right! Updated the PR and I am on the reset of the points!

@kiendang
Copy link
Collaborator

kiendang commented May 3, 2023

May as well update the other actions to latest versions too, actions/setup-python and actions/checkout.

@firaskafri firaskafri changed the title Tooling cleanups Workflows upgrades May 3, 2023
@kiendang
Copy link
Collaborator

kiendang commented May 3, 2023

Thanks for doing this. I've planned to do this as well since I did the exact same thing for graphql-server recently, but was waiting for #1365 to be merged.

@firaskafri
Copy link
Collaborator Author

firaskafri commented May 3, 2023

@kiendang thank you for reviewing this with me!
Linting is failing though, any idea why could this be happening?

Update: seems to be this https://github.com/graphql-python/graphene-django/blob/c1a22bfd91aa3b298ea8f293b1a9f6ece7a46a8e/.pre-commit-config.yaml#LL2C1-L2C1

@firaskafri firaskafri changed the title Workflows upgrades Upgraded github actions versions, default python and dev dependencies May 3, 2023
@firaskafri firaskafri changed the title Upgraded github actions versions, default python and dev dependencies Upgrade github actions versions, default python and dev dependencies May 3, 2023
@firaskafri firaskafri merged commit af8888f into main May 3, 2023
22 checks passed
@firaskafri firaskafri deleted the cleanup-upgrade-python-to-3.10 branch May 3, 2023 10:25
superlevure pushed a commit to loft-orbital/graphene-django that referenced this pull request Jul 19, 2023
…raphql-python#1407)

* Use Python 3.10 for deployments on PyPi

* Update gh-action-pypi-publish version

* Update python version

* Update checkout and setup-python versions

* Upgrade dev dependencies

* fromat examples and few files to follow black new version

* Upgrade pytest version

---------

Co-authored-by: Firas Kafri <firaskafri@Firass-MacBook-Pro-2.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants