Correct schema write test #1416
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firaskafri
approved these changes
May 27, 2023
<Mock>.called_once() just returns a Mock, so assert <Mock>.called_once() always passes. We want <Mock>.assert_called_once().
ulgens
force-pushed
the
fix-assert-called-once
branch
from
a5391a8
to
a04f011
Compare
ulgens
approved these changes
May 27, 2023
ulgens
approved these changes
May 27, 2023
ulgens
approved these changes
May 27, 2023
superlevure
pushed a commit
to loft-orbital/graphene-django
that referenced
this pull request
Jul 19, 2023
<Mock>.called_once() just returns a Mock, so assert <Mock>.called_once() always passes. We want <Mock>.assert_called_once().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discover this small "typo" while working on #1413.
<Mock>.called_once()just returns aMock, soassert <Mock>.called_once()always passes. We want<Mock>.assert_called_once().