Add check for serializers.HiddenField on fields_for_serializer function
#1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firaskafri
requested review from
ulgens,
sjdemartini,
kiendang,
jaw9c,
superlevure,
mahdyhamad and
firaskafri
sjdemartini
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
Looks good to me! Agreed this should be the behavior based on DRF docs on HiddenField saying
A field class that does not take a value based on user input, but instead takes its value from a default value or callable.
Thanks for adding the test!
firaskafri
approved these changes
Jun 6, 2023
superlevure
pushed a commit
to loft-orbital/graphene-django
that referenced
this pull request
Jul 19, 2023
…nction (graphql-python#1419) * Add check for `serializers.HiddenField` on fields_for_serializer function * Add pre-commit changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solves the issue that causes hidden fields to appear in Input when both
SerializerMutationand serializer class withHiddenFieldare used. This field class is usually used when you want to auto-populate a field, not filled by request's data. So, this field should not be appear in Input.