Update mutation.py to serialize Enum objects into input values #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allen-munsch
changed the title
|
Thanks @allen-munsch! Would you be able to add a unit test for this? It would be great to ensure we handle this example and prevent any future regressions. (Also, please run pre-commit formatting on the file per the failed CI job.) |
|
@sjdemartini I added a unit test, and ran the precommit hook. Looked like it was all green locally. Thank you for spending the time to review this. Much appreciated! |
firaskafri
approved these changes
Jul 21, 2023
sjdemartini
reviewed
Jul 24, 2023
…um objects into input values for ChoiceFields
sjdemartini
approved these changes
Jul 25, 2023
Co-authored-by: Steven DeMartini <1647130+sjdemartini@users.noreply.github.com>
|
@sjdemartini No problem. It really means a lot you were working through the backlog of issues. So I wanted to make sure I didn't let this one sit around. Cheers! |
superlevure
pushed a commit
to loft-orbital/graphene-django
that referenced
this pull request
Aug 9, 2023
…ql-python#1431) * Fix for issue graphql-python#1385: Update mutation.py to serialize Enum objects into input values for ChoiceFields * Update graphene_django/rest_framework/mutation.py Co-authored-by: Steven DeMartini <1647130+sjdemartini@users.noreply.github.com> --------- Co-authored-by: Steven DeMartini <1647130+sjdemartini@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1385