fix: foreign key nullable and custom resolver #1446
Merged
+86
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlevure
force-pushed
the
fix/foreign-key-nullable-custom-resolver
branch
from
d7f5ef4
to
e9bc96a
Compare
firaskafri
approved these changes
Aug 9, 2023
|
Thank you for your review @firaskafri, it seems that both @tcleonard and I lost our merge permissions, would you be able to do it? |
Sure! I just checked and I believe you and @tcleonard still have the write permissions though. |
superlevure
added a commit
to loft-orbital/graphene-django
that referenced
this pull request
Aug 10, 2023
* fix: nullable one to one relation * fix: makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
model.DoesNotExistexception when trying to resolve a null one-to-one relationship with a customget_querysetimplemented on theDjangoObjectType(see test)