Provide setting to enable/disable converting choices to enums globally #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flauschbaellchen
force-pushed
the
setting-convert-choices-to-enum
branch
3 times, most recently
from
95fb235
to
e9632d1
Compare
Flauschbaellchen
force-pushed
the
setting-convert-choices-to-enum
branch
from
e9632d1
to
c9af33a
Compare
| ): | ||
| if registry is not None: | ||
| converted = registry.get_converted_field(field) | ||
| if converted: | ||
| return converted | ||
| choices = getattr(field, "choices", None) | ||
| if convert_choices_to_enum is None: |
There was a problem hiding this comment.
A reason why I moved it into convert_django_field_with_choices and not implemented it on construct_fields or DjangoObjectType is, that django-graphene-plus uses convert_django_field_with_choices directly and would skip/ignore the setting or would need to manually look it up.
See: https://github.com/0soft/graphene-django-plus/blob/master/graphene_django_plus/input_types.py#L28
kiendang
reviewed
Dec 1, 2023
There was a problem hiding this comment.
Thanks @Flauschbaellchen for the PR. This sounds like a valid use case to me and the changes you proposed look backward-compatible too. I don't see a problem with merging this. Thoughts @sjdemartini @firaskafri?
sjdemartini
approved these changes
Dec 2, 2023
kiendang
approved these changes
Dec 20, 2023
superlevure
pushed a commit
to loft-orbital/graphene-django
that referenced
this pull request
Jan 30, 2024
graphql-python#1477) Co-authored-by: Firas Kafri <3097061+firaskafri@users.noreply.github.com> Co-authored-by: Kien Dang <mail@kien.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our project we want to disable the auto-convertion of Django choice fields to Enums for every model.
To specify
convert_choices_to_enum = Falseon everyTypeis a bit cumbersome so a global setting would help a lot.Any feedback is highly appreciated.
Closes #1480