(v3) Cast potentially translated strings used as descriptions #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…translation Before graphql-core had issues processing descriptions generated from translatable help_text during schema generation. Involved graphql-core utilities expect descriptions to be of type `str`, however, the generated descriptions were of type `django.utils.functional.__proxy__` which caused concatination with actual strings to fail.
DoctorJohn
changed the title
jkimbo
requested changes
Jun 6, 2020
|
I already took a look at both failing tests on my machine and I figured that their failure is not related to my changes (they already failed without my changes). I'm working on a patch to fix those tests but thought it would be better to submit it separately. |
Never mind, I might be mistaking. Lemme take another look |
DoctorJohn
force-pushed
the
v3-schema-generation-fix
branch
from
308511e
to
1a0fed0
Compare
|
@jkimbo I fixed the issue causing the tests to fail. Feel free to take another look |
|
Released a new beta version with this change |
andrei-datcu
added a commit
to andrei-datcu/graphene-django
that referenced
this pull request
Aug 11, 2021
graphql-python#976 casts all the description fields to strings to prevent schema printing from failing whenever the description is a lazy translated string. The `DecimalField` however got in after the v3 merge and it currently misses the cast.
tcleonard
pushed a commit
that referenced
this pull request
Sep 22, 2022
* Cast translated description for DecimalField #976 casts all the description fields to strings to prevent schema printing from failing whenever the description is a lazy translated string. The `DecimalField` however got in after the v3 merge and it currently misses the cast. * Fix row size
VV-YY
added a commit
to VV-YY/graphene-django
that referenced
this pull request
Jan 18, 2023
* Cast translated description for DecimalField graphql-python/graphene-django#976 casts all the description fields to strings to prevent schema printing from failing whenever the description is a lazy translated string. The `DecimalField` however got in after the v3 merge and it currently misses the cast. * Fix row size
paxaxel223
added a commit
to paxaxel223/graphe-django
that referenced
this pull request
Apr 25, 2023
* Cast translated description for DecimalField graphql-python/graphene-django#976 casts all the description fields to strings to prevent schema printing from failing whenever the description is a lazy translated string. The `DecimalField` however got in after the v3 merge and it currently misses the cast. * Fix row size
spartacus0816
pushed a commit
to spartacus0816/django_dev
that referenced
this pull request
May 22, 2023
* Cast translated description for DecimalField graphql-python/graphene-django#976 casts all the description fields to strings to prevent schema printing from failing whenever the description is a lazy translated string. The `DecimalField` however got in after the v3 merge and it currently misses the cast. * Fix row size
azuredevil0818
pushed a commit
to azuredevil0818/graphene-django
that referenced
this pull request
Jul 4, 2023
* Cast translated description for DecimalField graphql-python/graphene-django#976 casts all the description fields to strings to prevent schema printing from failing whenever the description is a lazy translated string. The `DecimalField` however got in after the v3 merge and it currently misses the cast. * Fix row size
superlevure
pushed a commit
to loft-orbital/graphene-django
that referenced
this pull request
Jul 19, 2023
* Cast translated description for DecimalField graphql-python#976 casts all the description fields to strings to prevent schema printing from failing whenever the description is a lazy translated string. The `DecimalField` however got in after the v3 merge and it currently misses the cast. * Fix row size
DevStar1016
added a commit
to DevStar1016/graphine-django
that referenced
this pull request
Sep 11, 2023
* Cast translated description for DecimalField graphql-python/graphene-django#976 casts all the description fields to strings to prevent schema printing from failing whenever the description is a lazy translated string. The `DecimalField` however got in after the v3 merge and it currently misses the cast. * Fix row size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #975 by explicitly casting all potentially translated strings used as descriptions to
str. (graphql-coreand itsprint_schemautility expects descriptions to be of typestr).