Fix filtering with GlobalIDFilter #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkimbo
requested changes
Jun 6, 2020
There was a problem hiding this comment.
This looks like a good change but the tests are failing @hubertsiuzdak
graphene_django/filter/fields.py
Outdated
Comment on lines
69
to
70
| else: | ||
| raise ValidationError(json.dumps(filterset.errors.get_json_data())) |
There was a problem hiding this comment.
Suggested change
| else: | |
| raise ValidationError(json.dumps(filterset.errors.get_json_data())) | |
| raise ValidationError(json.dumps(filterset.errors.get_json_data())) |
No need for the else statement.
hubertsiuzdak
force-pushed
the
master
branch
2 times, most recently
from
51d2020
to
434a776
Compare
hubertsiuzdak
commented
Jun 7, 2020
Comment on lines
+66
to
+68
| if filterset.form.is_valid(): | ||
| return filterset.qs | ||
| raise ValidationError(filterset.form.errors.as_json()) |
There was a problem hiding this comment.
To support Python 2.7 and django-filter 1.1 that form property is needed. In Graphene-Django v3 we use django-filter 2.x which allows to call is_valid and errors directly on filterset instances. We may want to refactor that for v3 as it slightly improves readability.
|
@jkimbo Can you take a look again? |
jkimbo
approved these changes
Jun 25, 2020
|
Thanks @hubertsiuzdak |
|
Released in v2.11.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #808, resolves #542
Filtering with not valid global ID doesn't raise any exception, and the query set without filter applied is returned instead. That happens due to the fact that django-filter no longer performs error handling itself (see carltongibson/django-filter#1078). This PR solves the issue by validating the filterset in DjangoFilterConnectionField.