Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set first amount to max limit if not set #993

Merged
merged 1 commit into from Jun 25, 2020
Merged

Set first amount to max limit if not set #993

merged 1 commit into from Jun 25, 2020

Conversation

jkimbo
Copy link
Member

@jkimbo jkimbo commented Jun 25, 2020

Related to #986

This PR fixes the issue with hasNextPage not being True when first is not passed to the query but RELAY_CONNECTION_MAX_LIMIT is set.

@jkimbo jkimbo mentioned this pull request Jun 25, 2020
Merged
ganwell
ganwell approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@ganwell ganwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkimbo jkimbo merged commit 3026181 into master Jun 25, 2020
@jkimbo jkimbo deleted the fix-relay-max-limit-no-first branch June 25, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganwell ganwell ganwell approved these changes

@zbyte64 zbyte64 Awaiting requested review from zbyte64

@ulgens ulgens Awaiting requested review from ulgens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkimbo @ganwell