Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an Aggregation section to the tips documentation page. #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

somada141
Copy link
Contributor

Added an Aggregation section to tips.rst to show how to retrieve the session out of info and perform an aggregation query wrapping the results in a custom type and exposing it to the schema.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.854% when pulling 28ae4ff on somada141:feature/doc-tips-aggregation into 33d5b74 on graphql-python:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.854% when pulling 28ae4ff on somada141:feature/doc-tips-aggregation into 33d5b74 on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.854% when pulling 28ae4ff on somada141:feature/doc-tips-aggregation into 33d5b74 on graphql-python:master.

@Nabellaleen
Copy link
Collaborator

@somada141 Nice example, but is it really related to graphene ?

The "tips" is "how to retrieve easily the sqlalchemy session from graphene context", but all the "what you can do with the query" is more sqlalchemy stuff than graphene stuff, no ?
So maybe most of the code you wrote should go as example in the appropriated directory instead of in the tips ?

(we can merge that this way and create a fully functional aggragation example later)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants