Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: configurable key to ID conversion #379

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

erikwrede
Copy link
Member

@erikwrede erikwrede commented Jan 27, 2023

fixes #102 by giving users the choice to either convert all Key Columns to graphene.ID or leave all key columns as is.

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ae4f87c) 94.74% compared to head (4947030) 96.30%.

❗ Current head 4947030 differs from pull request most recent head cb5dcf7. Consider uploading reports for the commit cb5dcf7 to get more accurate results

Files Patch % Lines
graphene_sqlalchemy/converter.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
+ Coverage   94.74%   96.30%   +1.55%     
==========================================
  Files          10        9       -1     
  Lines        1333      921     -412     
==========================================
- Hits         1263      887     -376     
+ Misses         70       34      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jendrikjoe jendrikjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest seems good. Maybe adding a test to ensure that actually querying an object returns as well the expected type (e.g. int not the converted id) might be helpful just for completeness 👍

graphene_sqlalchemy/converter.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic conversion from Int to ID is problematic
3 participants