Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: Add contains_exactly filter #391

Open
wants to merge 2 commits into
base: add-filters
Choose a base branch
from

Conversation

sabard
Copy link
Collaborator

@sabard sabard commented Apr 24, 2023

The contains_exactly filter implements relational division, essentially finding entities related to those specified exactly by a search criteria. That is, found entities should have no relations not specified by the search criteria.

contains_exactly was not working with async sqlalchemy 1.4 and was holding up #357, so it was removed. This PR adds back the feature.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage: 91.55% and project coverage change: -3.25 ⚠️

Comparison is base (a03a8b1) 96.37% compared to head (736f10d) 93.13%.

Additional details and impacted files
@@               Coverage Diff               @@
##           add-filters     #391      +/-   ##
===============================================
- Coverage        96.37%   93.13%   -3.25%     
===============================================
  Files                9       10       +1     
  Lines              773     1296     +523     
===============================================
+ Hits               745     1207     +462     
- Misses              28       89      +61     
Impacted Files Coverage Δ
graphene_sqlalchemy/registry.py 87.71% <75.86%> (-12.29%) ⬇️
graphene_sqlalchemy/enums.py 94.50% <83.33%> (-3.30%) ⬇️
graphene_sqlalchemy/types.py 89.76% <87.26%> (-4.60%) ⬇️
graphene_sqlalchemy/filters.py 89.61% <89.61%> (ø)
graphene_sqlalchemy/batching.py 95.34% <94.28%> (+1.59%) ⬆️
graphene_sqlalchemy/converter.py 95.86% <97.15%> (-0.34%) ⬇️
graphene_sqlalchemy/fields.py 98.64% <98.82%> (-0.39%) ⬇️
graphene_sqlalchemy/__init__.py 100.00% <100.00%> (ø)
graphene_sqlalchemy/resolvers.py 100.00% <100.00%> (ø)
graphene_sqlalchemy/utils.py 96.32% <100.00%> (+2.99%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant