Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve filter tests #402

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sabard
Copy link
Collaborator

@sabard sabard commented Mar 4, 2024

Add two filter tests covering RelationshipFilter exceptions and remove unnecessary code and comments relating to filtering and enums.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.46%. Comparing base (b30bc92) to head (bf65082).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
+ Coverage   94.76%   95.46%   +0.70%     
==========================================
  Files          10       10              
  Lines        1336     1324      -12     
==========================================
- Hits         1266     1264       -2     
+ Misses         70       60      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sabard sabard requested a review from erikwrede March 5, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant