Add Email type

[arunpkm]

Add Email type

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -1.09% ⚠️

Comparison is base (f5aba2c) 96.01% compared to head (f034de9) 94.92%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1514      +/-   ##
==========================================
- Coverage   96.01%   94.92%   -1.09%     
==========================================
  Files          51       52       +1     
  Lines        1755     1775      +20     
==========================================
  Hits         1685     1685              
- Misses         70       90      +20     

Files Changed	Coverage Δ
graphene/types/email.py	0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[erikwrede]

Hey @arunpkm, what exactly are you trying to achieve with this PR? While the addition of a custom Email Scalar might make sense for a clean schema design, I'm not sure wether this should be part of the graphene implementation.
The specifics of this scalar may vary from company to company as there may be more granular email rules than those defined in the RFCs mentioned by you. Consequently, it might make sense to leave this to the individual developers.

Aside from that, it is important to provide test cases and up to date documentation in the PR. Currently, the scalar doesn't seem to be doing any email validation. What are your plans for this, going forward? LMK what you think 😊