Get rid of Deprecation Warnings #1530
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pass fields param last try last try 2 re-try
patillacode
force-pushed
the
remove-deprecation-warnings
branch
from
4c81aec
to
63ca079
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1530 +/- ##
==========================================
- Coverage 96.01% 95.96% -0.05%
==========================================
Files 51 51
Lines 1755 1759 +4
==========================================
+ Hits 1685 1688 +3
- Misses 70 71 +1 ☔ View full report in Codecov by Sentry. |
|
Would it be possible to get this merged? |
|
Sorry for the late response. To me it looks like this is an issue that should be fixed in graphene_django, namely removing the use of a deprecated field in graphene. I'd prefer a solution that uses the newest standard in graphene instead of un-deprecating the deprecated option in the core library. Can you open a PR there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my current project which depends on
graphene(3.3) I encountered my logs unusable since they were heavily polluted with the following warning:While trying to fix it just by adding the
fields="__all__"option I stumbled upon this other one:I believe this PR would make those warnings disappear without breaking anything AFAIK, at least that is what I found while testing it.