Modernize #36
Modernize #36
Conversation
| "files": [ | ||
| "dist" | ||
| ], | ||
| "author": "David Chanin <chanindav@gmail.com>", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/ef-eng/graphql-query-rewriter" | ||
| "url": "https://github.com/ef-en/graphql-query-rewriter" |
There was a problem hiding this comment.
this URL isn't correct - should be https://github.com/graphql-query-rewriter/core
| - run: yarn install | ||
| - run: yarn lint | ||
| - run: yarn typecheck | ||
| - run: yarn test |
There was a problem hiding this comment.
also need to add yarn report-coverage and set up coveralls for GH actions
| }, | ||
| "scripts": { | ||
| "lint": "tslint --project tsconfig.json -t codeFrame 'src/**/*.ts' 'test/**/*.ts'", | ||
| "prebuild": "rimraf dist", | ||
| "build": "tsc --module commonjs && rollup -c rollup.config.ts && typedoc --out docs --target es6 --theme minimal --mode file src", |
There was a problem hiding this comment.
I think it's probably fine to get rid of rollup, just out of curiosity why remove it? Is it related to updating the node version? This wall all from https://github.com/alexjoverm/typescript-library-starter
There was a problem hiding this comment.
Yeah I saw the similarities, I reality I never saw something similar to that setup. If you look around all libs that mainly support node all use similar tsconfig and output commonjs code with types near the js code. So unless we need to do something fancy there is no need at this point to support es5/umd/other types of import.
Typedoc is still broken and I dont understand why, might be due to TypeStrong/typedoc#1493. Might have to revert to per 0.20.