Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use batchLoadFn.apply instead of directly invoking batchLoadFn #182

Merged
merged 2 commits into from Nov 13, 2019
Merged

use batchLoadFn.apply instead of directly invoking batchLoadFn #182

merged 2 commits into from Nov 13, 2019

Commits on Nov 13, 2019

  1. use batchLoadFn.apply instead of directly invoking batchLoadFn 

    use batchLoadFn.apply(loader,[keys]) instead of batchLoadFn(keys) to allow acces to the actual dataloader. Needed for example to use dataloader.prime() in the batch loader function.
    @jorisroling @leebyron
    jorisroling authored and leebyron committed Nov 13, 2019
    Copy the full SHA
    eac61e6 View commit details
    Browse the repository at this point in the history

  2. Add tests

    @leebyron
    leebyron committed Nov 13, 2019
    Copy the full SHA
    e06231c View commit details
    Browse the repository at this point in the history