fix: expose name in Dataloader instance types
#334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@saihaj perhaps you can help out with this one? Makes the new feature impossible to use in TS (as if you only have access to the dataloader instance you cannot safely read the name) |
henrinormak
changed the title
name in Dataloader instance types
saihaj
reviewed
Feb 8, 2023
| * | ||
| * Is `null` if not set in the constructor. | ||
| */ | ||
| name: string | null; |
There was a problem hiding this comment.
this can also be undefined given in config it is name?: string | null if you don't give a name then that is undefined
There was a problem hiding this comment.
Actually, the constructor then defaults to null - https://github.com/graphql/dataloader/blob/main/src/index.js#L478-L484
The config also specifically mentions this defaulting - https://github.com/graphql/dataloader/blob/main/src/index.d.ts#L124
saihaj
reviewed
Feb 8, 2023
|
Added the changeset |
saihaj
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #331 and #326
This corrects the types, as the name property is also exposed on the Dataloader instance, not only in the config. Tests already test for this, but as they are not in TS, the types were not checked.