Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][reference] Integrate graphql-js experimental parser #1653

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thenamankumar
Copy link
Contributor

@thenamankumar thenamankumar commented Aug 30, 2020

This PR is in progress and contains the work done under GSOC2020

It integrates the experimental online parser from graphql-js in place of the graphiql parser. graphql/graphql-js#2770

[x] Integrate with graphql mode in codemirror and support syntax highlighting
[ ] Update auto suggestion utils

@acao
Copy link
Member

acao commented Aug 30, 2020

awesome! needs to be added to the LSP (gls-interface) as well, for LSP server and codemirror/monaco-graphql

@acao acao force-pushed the main branch 6 times, most recently from 4fa9ca3 to 1c11938 Compare February 1, 2021 18:22
@saihaj
Copy link
Member

saihaj commented Nov 5, 2021

During migration we decided to drop it. Need to re-write in TS with more tests see graphql/graphql-js#3031

@acao acao changed the title [WIP] Integrate graphql-js experimental parser [WIP][reference] Integrate graphql-js experimental parser Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants