New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not clear headers when switching between tabs #3552
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 94b09ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
good find, thank you! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3552 +/- ##
==========================================
- Coverage 55.33% 55.32% -0.01%
==========================================
Files 115 115
Lines 5349 5348 -1
Branches 1450 1450
==========================================
- Hits 2960 2959 -1
+ Misses 1963 1962 -1
- Partials 426 427 +1
|
@acao Would it be OK to merge? |
241bb5b
to
f87c895
Compare
I pushed another commit since it would just use whatever you have in the editor and not overwrite it, using default headers is a better choice when switching tabs. Before:
|
I have two PRs open that initially seem well received, how come we don't move forward and merge if they are perceived as good changes? @acao |
d7f9b27
to
94b09ad
Compare
Issue
When switching between tabs, the default header state is lost and replaced with empty string.
Demo of the bug:
Screen.Recording.2024-03-06.at.10.47.10.mov
Codepen to verify/reproduce the issue:
In this example we are using defaultHeaders, and when using multiple tabs, upon reload the headers are cleared when switching tabs.
https://codesandbox.io/p/sandbox/determined-brook-rp683x?file=/package.json:11,23
Note: If you edit the headers before switching tabs, they are not cleared. I am guessing that they are then instead stored in the internal state.