Improve parser location API (#3061)

This replaces manual assignment of `loc` on each node in Parser with a `node()` function. This simplifies the parser and also ensures the `loc` field does not appear at all when `noLocation` is provided.
graphql · May 6, 2021 · 002fb91 · 002fb91
1 parent a4e9bc9
commit 002fb91
Show file tree

Hide file tree

Showing 3 changed files with 104 additions and 158 deletions.
diff --git a/src/language/parser.d.ts b/src/language/parser.d.ts
@@ -3,7 +3,6 @@ import { GraphQLError } from '../error/GraphQLError';
 
 import {
   Token,
-  Location,
   NameNode,
   VariableNode,
   DocumentNode,
@@ -501,9 +500,11 @@ export declare class Parser {
   parseDirectiveLocation(): NameNode;
 
   /**
-   * Returns a location object, used to identify the place in the source that created a given parsed object.
+   * Returns a node that, if configured to do so, sets a "loc" field as a
+   * location object, used to identify the place in the source that created a
+   * given parsed object.
    */
-  loc(startToken: Token): Location | undefined;
+  node<T>(startToken: Token, node: T): T;
 
   /**
    * Determines if the next token is of a given kind